Skip to content

Zeversolar integration#84887

Merged
frenck merged 12 commits into
home-assistant:devfrom
kvanzuijlen:zeversolar-integration
Jan 3, 2023
Merged

Zeversolar integration#84887
frenck merged 12 commits into
home-assistant:devfrom
kvanzuijlen:zeversolar-integration

Conversation

@kvanzuijlen
Copy link
Copy Markdown
Contributor

@kvanzuijlen kvanzuijlen commented Dec 31, 2022

Proposed change

Add integration for Zeversolar solar panels.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Original PR where I messed up the commit author: #84876

@kvanzuijlen
Copy link
Copy Markdown
Contributor Author

@MartinHjelmare @frenck Started a new PR as suggested, and cherrypicked my commits on the previous branch. All should be fine now.

Sorry for the mess.

@kvanzuijlen kvanzuijlen force-pushed the zeversolar-integration branch from 12793aa to 9f55363 Compare December 31, 2022 00:41
@kvanzuijlen
Copy link
Copy Markdown
Contributor Author

CLA comment has been fixed, had it configured that way somewhere else as well...

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure the CI passes.

../Frenck

@kvanzuijlen
Copy link
Copy Markdown
Contributor Author

@frenck I'm now fixing the unit tests. Do you want me to fix the deprecation warnings for the converters as well, or rather in a separate PR?

@kvanzuijlen kvanzuijlen requested a review from frenck December 31, 2022 19:48
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of small comments left, otherwise it looks good 👍

Comment thread homeassistant/components/zeversolar/strings.json Outdated
Comment thread homeassistant/components/zeversolar/translations/en.json Outdated
Comment thread homeassistant/components/zeversolar/manifest.json Outdated
Comment thread homeassistant/components/zeversolar/entity.py
kvanzuijlen and others added 3 commits January 3, 2023 16:36
@kvanzuijlen kvanzuijlen requested a review from frenck January 3, 2023 17:01
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks, @kvanzuijlen 👍

Happy New Year 🥂

../Frenck

@frenck frenck merged commit 6349760 into home-assistant:dev Jan 3, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants