Zeversolar integration#84887
Merged
Merged
Conversation
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Contributor
Author
|
@MartinHjelmare @frenck Started a new PR as suggested, and cherrypicked my commits on the previous branch. All should be fine now. Sorry for the mess. |
This was referenced Dec 31, 2022
12793aa to
9f55363
Compare
Contributor
Author
|
CLA comment has been fixed, had it configured that way somewhere else as well... |
frenck
requested changes
Dec 31, 2022
Member
frenck
left a comment
There was a problem hiding this comment.
Please make sure the CI passes.
../Frenck
Contributor
Author
|
@frenck I'm now fixing the unit tests. Do you want me to fix the deprecation warnings for the converters as well, or rather in a separate PR? |
frenck
requested changes
Jan 3, 2023
Member
frenck
left a comment
There was a problem hiding this comment.
A couple of small comments left, otherwise it looks good 👍
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
frenck
approved these changes
Jan 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Add integration for Zeversolar solar panels.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests:
Original PR where I messed up the commit author: #84876