Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to pytest-freezer #84680

Merged
merged 1 commit into from
Dec 28, 2022
Merged

Switch to pytest-freezer #84680

merged 1 commit into from
Dec 28, 2022

Conversation

elupus
Copy link
Contributor

@elupus elupus commented Dec 28, 2022

Proposed change

  • Switch to pytest-dev maintained freezer package instead of pytest-freezegun since the old repository is using deprecated features.
  • Diff between version 0.4.2, which is a very close copy of pytest-freezegun 0.4.2, and 0.4.6:
    pytest-dev/pytest-freezer@0.4.2...0.4.6

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

============================================================================================== warnings summary ==============================================================================================
venv/lib/python3.10/site-packages/pytest_freezegun.py:17: 48 warnings
  /Users/joakim/src/hass/home-assistant/venv/lib/python3.10/site-packages/pytest_freezegun.py:17: DeprecationWarning: distutils Version classes are deprecated. Use packaging.version instead.
    if LooseVersion(pytest.__version__) < LooseVersion('3.6.0'):

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@epenet
Copy link
Contributor

epenet commented Dec 28, 2022

Makes sense.
Could you add a link to the release notes?

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

I added a link to the version diff of pytest-freezer.

@elupus
Copy link
Contributor Author

elupus commented Dec 28, 2022

Thanks!

@elupus elupus merged commit 850c082 into home-assistant:dev Dec 28, 2022
@elupus elupus deleted the testing/freezer branch December 28, 2022 14:43
@github-actions github-actions bot locked and limited conversation to collaborators Dec 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants