Skip to content

Add mysensors text platform#84667

Merged
frenck merged 4 commits into
devfrom
add-mysensors-text
Dec 29, 2022
Merged

Add mysensors text platform#84667
frenck merged 4 commits into
devfrom
add-mysensors-text

Conversation

@MartinHjelmare
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare commented Dec 27, 2022 •
edited
Loading

Breaking change

Proposed change

  • Add a text platform for the mysensors integration.
  • The text platform will replace the notify platform, which is deprecated.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Dec 27, 2022

Hey there @functionpointer, mind taking a look at this pull request as it has been labeled with an integration (mysensors) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of mysensors can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign mysensors Removes the current integration label and assignees on the issue, add the integration domain after the command.

@MartinHjelmare MartinHjelmare mentioned this pull request Dec 28, 2022
Merged
8 tasks
@MartinHjelmare MartinHjelmare marked this pull request as ready for review December 28, 2022 00:00
@MartinHjelmare
Copy link
Copy Markdown
Member Author

MartinHjelmare commented Dec 28, 2022 •
edited
Loading

Since the beta cut is today, and I have another planned deprecation for this integration, I'll put this in draft so we can coordinate all the deprecations and later breaking changes in the same releases.

@MartinHjelmare MartinHjelmare marked this pull request as draft December 28, 2022 12:21
@MartinHjelmare
Copy link
Copy Markdown
Member Author

MartinHjelmare commented Dec 28, 2022

Beta has been cut. 👍

@MartinHjelmare MartinHjelmare marked this pull request as ready for review December 28, 2022 16:43
MartinHjelmare
MartinHjelmare commented Dec 28, 2022
View reviewed changes
Comment thread homeassistant/components/mysensors/notify.py Outdated
bdraco
bdraco reviewed Dec 29, 2022
View reviewed changes
Comment thread homeassistant/components/mysensors/text.py Outdated
bdraco
bdraco reviewed Dec 29, 2022
View reviewed changes
Comment thread homeassistant/components/mysensors/text.py
from .. import mysensors
from .const import MYSENSORS_DISCOVERY, DiscoveryInfo
from .device import MySensorsEntity
from .helpers import on_unload
Copy link
Copy Markdown
Member

@bdraco bdraco Dec 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preference: I probably would have named this async_on_unload

Copy link
Copy Markdown
Member Author

@MartinHjelmare MartinHjelmare Dec 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, when all the platforms are migrated to config entry setup, I'll remove this and just use the builtin entry.async_on_unload.

@MartinHjelmare @bdraco
Fix docstring
1853904 
Co-authored-by: J. Nick Koston <nick@koston.org>
@MartinHjelmare
Copy link
Copy Markdown
Member Author

MartinHjelmare commented Dec 29, 2022

Thanks!

frenck
frenck approved these changes Dec 29, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

@frenck frenck merged commit 5d4216d into dev Dec 29, 2022
@frenck frenck deleted the add-mysensors-text branch December 29, 2022 23:01
weisserd pushed a commit to weisserd/core that referenced this pull request Dec 30, 2022
@MartinHjelmare @bdraco @weisserd
Add mysensors text platform (home-assistant#84667)
f62f9c7 
Co-authored-by: J. Nick Koston <nick@koston.org>
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@frenck frenck frenck approved these changes

@bdraco bdraco bdraco approved these changes

Assignees

No one assigned

Labels

by-code-owner cla-signed deprecation Indicates a breaking change to happen in the future has-tests integration: mysensors new-feature Quality Scale: No score

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MartinHjelmare @frenck @bdraco