Skip to content

Retry ZHA config entry setup when ENETUNREACH is caught#84615

Merged
elupus merged 2 commits into
home-assistant:devfrom
puddly:puddly/zha-retry-on-network-error
Jan 7, 2023
Merged

Retry ZHA config entry setup when ENETUNREACH is caught#84615
elupus merged 2 commits into
home-assistant:devfrom
puddly:puddly/zha-retry-on-network-error

Conversation

@puddly
Copy link
Copy Markdown
Contributor

@puddly puddly commented Dec 27, 2022

Proposed change

If the network is down and connecting to a TCP coordinator fails with ENETUNREACH, retry ZHA setup at a later time instead of permanently failing.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @dmulcahey, @Adminiuga, mind taking a look at this pull request as it has been labeled with an integration (zha) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of zha can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign zha Removes the current integration label and assignees on the issue, add the integration domain after the command.

Copy link
Copy Markdown
Contributor

@Adminiuga Adminiuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@puddly puddly added this to the 2022.12.9 milestone Dec 27, 2022
@elupus
Copy link
Copy Markdown
Contributor

elupus commented Dec 28, 2022

This seem like something that should be caught in the library and wrapped in a known lib exception?

@puddly puddly force-pushed the puddly/zha-retry-on-network-error branch from afaf8d6 to b3fdc5f Compare January 7, 2023 05:13
@puddly
Copy link
Copy Markdown
Contributor Author

puddly commented Jan 7, 2023

Rewritten to use zigpy.exceptions.TransientConnectionError now that #85355 has been merged into dev.

@elupus elupus merged commit 757e4cf into home-assistant:dev Jan 7, 2023
@TheJulianJES
Copy link
Copy Markdown
Member

Should this still be included in a hotfix release? (Currently, the PR has the 2022.12.9 milestone instead of 2023.1.x)

@puddly puddly modified the milestones: 2022.12.9, 2023.1.2 Jan 7, 2023
@puddly
Copy link
Copy Markdown
Contributor Author

puddly commented Jan 7, 2023

Thanks! I've updated the milestone.

@github-actions github-actions Bot locked and limited conversation to collaborators Jan 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EZSP start attempts not enough to start ZHA

6 participants