Retry ZHA config entry setup when ENETUNREACH is caught#84615
Merged
elupus merged 2 commits intoJan 7, 2023
Conversation
Contributor
|
Hey there @dmulcahey, @Adminiuga, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
|
This seem like something that should be caught in the library and wrapped in a known lib exception? |
afaf8d6 to
b3fdc5f
Compare
Contributor
Author
|
Rewritten to use |
elupus
approved these changes
Jan 7, 2023
Member
|
Should this still be included in a hotfix release? (Currently, the PR has the 2022.12.9 milestone instead of 2023.1.x) |
Contributor
Author
|
Thanks! I've updated the milestone. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
If the network is down and connecting to a TCP coordinator fails with
ENETUNREACH, retry ZHA setup at a later time instead of permanently failing.Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: