Add Bridge module to AsusWRT#84152
Conversation
|
Hey there @kennedyshead, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
813a333 to
4541fb7
Compare
59215cd to
d590434
Compare
15cad0b to
b0b0742
Compare
|
What help can I provide to get your updated code acceptable to merge? |
|
The point is have a ha team member that review the PR. This is up to them. |
99056bc to
9a97685
Compare
9a97685 to
4fe7262
Compare
3a6bd41 to
2ccca8c
Compare
This comment was marked as resolved.
This comment was marked as resolved.
There are no change in the coordinator function here. This would happen here as in the version without bridge and exception is managed by coordinator. Do you mean that I should catch this exception and raise and |
Yes, those exceptions should end with |
bieniu
left a comment
There was a problem hiding this comment.
Please add IndexError to these two methods. This will fix the two exceptions I got a few days ago.
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Added also to |
|
@ollo69 Please tag me in the next PRs you open to implement http communication and I'll try to help with the review. |
Ok, thanks. I'll start working on this shortly. |
Proposed change
I'm trying to split PR #71899 in multiple smaller parts.
This first PR just introduces the
bridgemodule, that implement an abstractAsusWrtBridgeclass that than is derived to use a specific library (like SamsungTV integration bridge module).With this PR there are no changes in integration functionality.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: