Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump androidtv dependency of androitv component #83707

Merged
merged 1 commit into from
Dec 10, 2022

Conversation

chatziko
Copy link
Contributor

Bump dependency to version 0.0.70

Changes in upstream dependency: JeffLIrion/python-androidtv@v0.0.69...v0.0.70

Fixes #80555

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @JeffLIrion, @ollo69, mind taking a look at this pull request as it has been labeled with an integration (androidtv) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of androidtv can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign androidtv Removes the current integration label and assignees on the issue, add the integration domain after the command.

@chatziko
Copy link
Contributor Author

There seems to be 1 failed test, but unrelated to this PR.

Note that the same exact commit passes all tests on my fork:
https://github.com/chatziko/home-assistant-core/actions/runs/3664456933
(some test has non-deterministic behaviour?)

@ollo69
Copy link
Contributor

ollo69 commented Dec 10, 2022

There seems to be 1 failed test, but unrelated to this PR.

Failing test is about:

 ERROR tests/components/nina/test_config_flow.py::test_options_flow_entity_removal

Because test python run test on all components, a failing test on other component can cause this, Not clear way this happen because that failing test should not be in dev env. You could try to rebase and see if the error is gone.

@chatziko
Copy link
Contributor Author

Because test python run test on all components, a failing test on other component can cause this, Not clear way this happen because that failing test should not be in dev env. You could try to rebase and see if the error is gone.

Just rebased, everything passed now 😄

(Note that the same exact commit that was failing here, in my fork it was passing all tests, so it doesn't look like a problem with some other component but rather a non-deterministic test behavior.)

@thecode thecode added this to the 2022.12.2 milestone Dec 10, 2022
@thecode thecode merged commit 3c704ba into home-assistant:dev Dec 10, 2022
balloob pushed a commit that referenced this pull request Dec 11, 2022
@balloob balloob mentioned this pull request Dec 11, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chromecast with Google TV devices updated to Android 12 not working correctly with Android TV integration
4 participants