Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fibaro climate unit #83659

Merged
merged 1 commit into from
Dec 10, 2022
Merged

Conversation

rappenze
Copy link
Contributor

@rappenze rappenze commented Dec 9, 2022

Proposed change

In rare cases fibaro device climate devices do not report unit.
Just added a check to test that unit exists really. Anyway in such cases often there is a second device which forms together the climate entity and the unit is read then from there (code for that fallback exists already).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@thecode thecode merged commit 119f2a9 into home-assistant:dev Dec 10, 2022
@thecode thecode added this to the 2022.12.2 milestone Dec 10, 2022
@thecode
Copy link
Member

thecode commented Dec 10, 2022

Thanks!

balloob pushed a commit that referenced this pull request Dec 11, 2022
@balloob balloob mentioned this pull request Dec 11, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2022
@rappenze rappenze deleted the fix_fibaro_climate_unit branch March 11, 2023 20:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fibaro integration : Climate error
3 participants