Skip to content

Fix pathlib resolve#8311

Merged
pvizeli merged 2 commits into
home-assistant:devfrom
pvizeli:fix_pathlib_resolve
Jul 3, 2017
Merged

Fix pathlib resolve#8311
pvizeli merged 2 commits into
home-assistant:devfrom
pvizeli:fix_pathlib_resolve

Conversation

@pvizeli
Copy link
Copy Markdown
Member

@pvizeli pvizeli commented Jul 3, 2017

Description:

Fix to save the return value of resove.

Related issue (if applicable): fixes #8291

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@pvizeli pvizeli added this to the 0.48.1 milestone Jul 3, 2017
@mention-bot
Copy link
Copy Markdown

@pvizeli, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob, @fabaff and @jaharkes to be potential reviewers.

@balloobbot balloobbot added the core label Jul 3, 2017
@pvizeli pvizeli merged commit ee7d471 into home-assistant:dev Jul 3, 2017
@balloob
Copy link
Copy Markdown
Member

balloob commented Jul 5, 2017

Cherry picked for 0.48.1

balloob pushed a commit that referenced this pull request Jul 5, 2017
* Fix pathlib resolve

* fix test
@balloob balloob mentioned this pull request Jul 5, 2017
@balloob balloob mentioned this pull request Jul 13, 2017
dethpickle pushed a commit to dethpickle/home-assistant that referenced this pull request Aug 18, 2017
* Fix pathlib resolve

* fix test
@home-assistant home-assistant locked and limited conversation to collaborators Oct 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

hass.config.is_allowed_path vulnerable to path traversal

5 participants