Upnp mapping notification#8303
Merged
Merged
Conversation
Latest version of miniupnpc is 2.0, but pypi only has 1.9 Fortunately it is enough
miniupnpc will do network calls, so this component can’t be moved to coroutine
|
@dgomes, thanks for your PR! By analyzing the history of the files in this pull request, we identified @robbiet480 and @fabaff to be potential reviewers. |
houndci-bot
reviewed
Jul 2, 2017
| external_port, 'TCP', host, internal_port, 'Home Assistant', '') | ||
| internal_port = base_url.port | ||
| external_port = int(config[DOMAIN].get(CONF_EXTERNAL_PORT)) | ||
|
|
balloob
approved these changes
Jul 7, 2017
Merged
dethpickle
pushed a commit
to dethpickle/home-assistant
that referenced
this pull request
Aug 18, 2017
* make port mapping optional * dependencies + improvements * Added bytes and packets sensors from IGD * flake8 check * new sensor with upnp counters * checks * whitespaces in blank line * requirements update * added sensor.upnp to .coveragerc * downgrade miniupnpc Latest version of miniupnpc is 2.0, but pypi only has 1.9 Fortunately it is enough * revert to non async miniupnpc will do network calls, so this component can’t be moved to coroutine * hof hof forgot to remove import ot asyncio * UPnP mapping overlap Addressing: https://community.home-assistant.io/t/upnp-new-module/20839 * removed whitespaces
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This pull request addresses an issue identified in https://community.home-assistant.io/t/upnp-new-module/20839
Related issue (if applicable): fixes #8067
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#2924
Example entry for
configuration.yaml(if applicable):Checklist:
If user exposed functionality or configuration variables are added/changed: