Upgrade pytest-aiohttp by elupus · Pull Request #82475 · home-assistant/core

elupus · 2022-11-21T11:46:26Z

Proposed change

Attempt to bump pytest-aiohttp

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Deprecation (breaking change to happen in the future)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Additional information

Checklist

The code change is tested and works locally.
Local tests pass. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist
The code has been formatted using Black (black --fast homeassistant tests)
Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

I have reviewed two other open pull requests in this repository.

homeassistant/components/lifx/__init__.py

janiversen

LGTM.

elupus · 2022-11-27T17:32:56Z

tests/components/energy/test_sensor.py

+    """Freeze clock for tests."""
+    yield
+
+


A bit unclear if this is needed after the garbage collect change. But i still think it make sense.

elupus · 2022-11-27T17:34:35Z

tests/conftest.py

    yield

+    event_loop.run_until_complete(event_loop.shutdown_default_executor())
+


If we could ignore the executor threads easily in the below threads check, we dont need to stop these here.

frenck

@elupus A merge conflict appeared; otherwise, it looks good to me (and I don't have an answer for excluding the executor threads above).

Some test will trigger warnings on garbage collect, these warnings spills over into next test. Some test trigger tasks that raise errors on shutdown, these spill over into next test. This is to mimic older pytest-aiohttp and it's behaviour on test cleanup. Discussions on similar changes for pytest-aiohttp are here: pytest-dev/pytest-asyncio#309

/home-assistant/homeassistant/helpers/template.py:2082: RuntimeWarning: coroutine 'AsyncMockMixin._execute_mock_call' was never awaited def wrapper(*args, **kwargs): Enable tracemalloc to get traceback where the object was allocated. See https://docs.pytest.org/en/stable/how-to/capture-warnings.html#resource-warnings for more info.

The times are simulated anyway, and we can't stop the normal event from occuring.

tests/components/motioneye/test_camera.py::test_get_still_image_from_camera tests/components/motioneye/test_camera.py::test_get_still_image_from_camera tests/components/motioneye/test_camera.py::test_get_stream_from_camera tests/components/motioneye/test_camera.py::test_get_stream_from_camera tests/components/motioneye/test_camera.py::test_camera_option_stream_url_template tests/components/motioneye/test_camera.py::test_camera_option_stream_url_template /Users/joakim/src/hass/home-assistant/venv/lib/python3.9/site-packages/aiohttp/web_urldispatcher.py:189: DeprecationWarning: Bare functions are deprecated, use async ones warnings.warn(

The tests allowed clock to tick in between steps

Old tests would trigger attempts to post to could services: ``` DEBUG:aioskybell:HTTP post https://cloud.myskybell.com/api/v3/login/ Request with headers: {'content-type': 'application/json', 'accept': '*/*', 'x-skybell-app-id': 'd2b542c7-a7e4-4e1e-b77d-2b76911c7c46', 'x-skybell-client-id': '1f36a3c0-6dee-4997-a6db-4e1c67338e57'} ```

MartinHjelmare · 2022-11-30T03:30:39Z

tests/conftest.py

+    # before moving on to the next test.
+    tasks = asyncio.all_tasks(event_loop) - tasks_before
+    for task in tasks:
+        warnings.warn(f"Linger task after test {task}")


Lingering task

MartinHjelmare · 2022-11-30T03:31:28Z

tests/conftest.py

+            handle.cancel()
+
+    # Make sure garbage collect run in same test as allocation
+    # this is to mimic the behavior of pytest-aiohttp, and is


Start a new sentence on this line.

* Upgrade pytest-aiohttp * Make sure executors, tasks and timers are closed Some test will trigger warnings on garbage collect, these warnings spills over into next test. Some test trigger tasks that raise errors on shutdown, these spill over into next test. This is to mimic older pytest-aiohttp and it's behaviour on test cleanup. Discussions on similar changes for pytest-aiohttp are here: pytest-dev/pytest-asyncio#309 * Replace loop with event_loop * Make sure time is frozen for tests * Make sure the ConditionType is not async /home-assistant/homeassistant/helpers/template.py:2082: RuntimeWarning: coroutine 'AsyncMockMixin._execute_mock_call' was never awaited def wrapper(*args, **kwargs): Enable tracemalloc to get traceback where the object was allocated. See https://docs.pytest.org/en/stable/how-to/capture-warnings.html#resource-warnings for more info. * Increase litejet press tests with a factor 10 The times are simulated anyway, and we can't stop the normal event from occuring. * Use async handlers for aiohttp tests/components/motioneye/test_camera.py::test_get_still_image_from_camera tests/components/motioneye/test_camera.py::test_get_still_image_from_camera tests/components/motioneye/test_camera.py::test_get_stream_from_camera tests/components/motioneye/test_camera.py::test_get_stream_from_camera tests/components/motioneye/test_camera.py::test_camera_option_stream_url_template tests/components/motioneye/test_camera.py::test_camera_option_stream_url_template /Users/joakim/src/hass/home-assistant/venv/lib/python3.9/site-packages/aiohttp/web_urldispatcher.py:189: DeprecationWarning: Bare functions are deprecated, use async ones warnings.warn( * Switch to freezegun in modbus tests The tests allowed clock to tick in between steps * Make sure skybell object are fully mocked Old tests would trigger attempts to post to could services: ``` DEBUG:aioskybell:HTTP post https://cloud.myskybell.com/api/v3/login/ Request with headers: {'content-type': 'application/json', 'accept': '*/*', 'x-skybell-app-id': 'd2b542c7-a7e4-4e1e-b77d-2b76911c7c46', 'x-skybell-client-id': '1f36a3c0-6dee-4997-a6db-4e1c67338e57'} ``` * Fix sorting that broke after rebase

home-assistant bot added cla-signed code-quality core small-pr PRs with less than 30 lines. labels Nov 21, 2022

elupus force-pushed the pytest/asyncio branch from 2c1f3fd to c07b5e8 Compare November 21, 2022 13:40

bdraco reviewed Nov 21, 2022

View reviewed changes

homeassistant/components/lifx/__init__.py Outdated Show resolved Hide resolved

elupus force-pushed the pytest/asyncio branch 2 times, most recently from cb60dbf to 739c17a Compare November 21, 2022 19:52

elupus mentioned this pull request Nov 21, 2022

Unsubscribe will not actually cancel the background task ludeeus/aiogithubapi#154

Closed

elupus force-pushed the pytest/asyncio branch 6 times, most recently from 4d1335f to 7605ce5 Compare November 27, 2022 10:11

elupus marked this pull request as ready for review November 27, 2022 12:38

elupus requested review from a team, allenporter, janiversen, ludeeus and ochlocracy as code owners November 27, 2022 12:38

bdraco approved these changes Nov 27, 2022

View reviewed changes

janiversen approved these changes Nov 27, 2022

View reviewed changes

elupus commented Nov 27, 2022

View reviewed changes

frenck approved these changes Nov 29, 2022

View reviewed changes

elupus added 4 commits November 29, 2022 21:14

Upgrade pytest-aiohttp

ea78c09

Replace loop with event_loop

72b5fca

Make sure time is frozen for tests

194c8c5

elupus added 5 commits November 29, 2022 21:18

Increase litejet press tests with a factor 10

ef8df5a

The times are simulated anyway, and we can't stop the normal event from occuring.

Switch to freezegun in modbus tests

2a208d0

The tests allowed clock to tick in between steps

elupus force-pushed the pytest/asyncio branch from d89dcf2 to f8ff685 Compare November 29, 2022 20:18

elupus requested a review from jbouwh as a code owner November 29, 2022 20:18

Fix sorting that broke after rebase

f48843a

jbouwh approved these changes Nov 29, 2022

View reviewed changes

elupus merged commit c576a68 into home-assistant:dev Nov 29, 2022

elupus deleted the pytest/asyncio branch November 29, 2022 21:36

MartinHjelmare reviewed Nov 30, 2022

View reviewed changes

github-actions bot locked and limited conversation to collaborators Dec 1, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Upgrade pytest-aiohttp#82475

Upgrade pytest-aiohttp#82475
elupus merged 10 commits intohome-assistant:devfrom
elupus:pytest/asyncio

elupus commented Nov 21, 2022 •

edited

Loading

Uh oh!

Uh oh!

janiversen left a comment

Uh oh!

elupus Nov 27, 2022

Uh oh!

elupus Nov 27, 2022

Uh oh!

frenck left a comment

Uh oh!

MartinHjelmare Nov 30, 2022

Uh oh!

MartinHjelmare Nov 30, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

		yield

		event_loop.run_until_complete(event_loop.shutdown_default_executor())

Uh oh!

Conversation

elupus commented Nov 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed change

Type of change

Additional information

Checklist

Uh oh!

Uh oh!

janiversen left a comment

Choose a reason for hiding this comment

Uh oh!

elupus Nov 27, 2022

Choose a reason for hiding this comment

Uh oh!

elupus Nov 27, 2022

Choose a reason for hiding this comment

Uh oh!

frenck left a comment

Choose a reason for hiding this comment

Uh oh!

MartinHjelmare Nov 30, 2022

Choose a reason for hiding this comment

Uh oh!

MartinHjelmare Nov 30, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

elupus commented Nov 21, 2022 •

edited

Loading