Docker cleanup#8226
Merged
Merged
Conversation
balloob
approved these changes
Jun 30, 2017
Member
|
Awesome. Thanks! I'll try to pay better attention when I see PRs come in for Docker. |
Merged
dethpickle
pushed a commit
to dethpickle/home-assistant
that referenced
this pull request
Aug 18, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the last Docker related cleanup, hass gained some weight again. This was mainly due to external packages that had to be compiled from source that didn't cleanup their sources after installing the binaries.
Docker-related changes:
.dockerignorewith files that aren't related for Docker. This is mainly to speed up development in Docker, since the image that dockerhub creates is usually quite clean.Dockerfile.devwithDockerfile(add the uninstall ofenum34toDockerfile.dev)Dockerfileto also updateDockerfile.dev/usr/src/app/build/for temporary build storage, and make sure this folder is cleaned up. All scripts install the binaries to a system path, so the sources can be removed.Before these changes, the
setup_docker_prereqsscript added 463 MB to the image. After these changes, it adds 370 MB, so we lost 93poundsmegabytes!Before:
After: