Skip to content

Remove unnecessary thread_ident assignment #8194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emlove merged 2 commits into from
Jun 25, 2017
Merged

Remove unnecessary thread_ident assignment #8194

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
278e18d
Remove mocking of _thread_ident
emlove Jun 25, 2017
2a1f3cf
Re-add run_loop thread_ident assignment
emlove Jun 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions tests/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,6 @@ def stop_hass():
@asyncio.coroutine
def async_test_home_assistant(loop):
"""Return a Home Assistant object pointing at test config dir."""
loop._thread_ident = threading.get_ident()
Copy link
Copy Markdown
Member

@balloob balloob Jun 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is inside the async thread because it's run inside a coroutine. However, I do realize now that this might actually not be the case because during the fixture we're calling loop.run_until_complete, which means that we're actually in a thread that executes the fixture!

We need to somehow schedule this so that it gets executed on the loop.

Copy link
Copy Markdown
Member

@balloob balloob Jun 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we should remove it regardless, as it's wrong.


hass = ha.HomeAssistant(loop)
INSTANCES.append(hass)

Expand Down