Skip to content

Address late review of config entry wait for states tests #81801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MartinHjelmare merged 2 commits into from
Nov 8, 2022
Merged

Address late review of config entry wait for states tests #81801

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6faa0c
Late review on tests #81771
jbouwh Nov 8, 2022
20664a1
Clean-up duplicate assignment
jbouwh Nov 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 9 additions & 17 deletions tests/test_config_entries.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3332,7 +3332,7 @@ async def test_reauth(hass):
assert len(hass.config_entries.flow.async_progress()) == 2


async def test_wait_for_loading_entry(hass):
async def test_wait_for_loading_entry(hass: HomeAssistant) -> None:
"""Test waiting for entry to be set up."""

entry = MockConfigEntry(title="test_title", domain="test")
Expand All @@ -3346,15 +3346,13 @@ async def test_wait_for_loading_entry(hass):

flow = hass.config_entries.flow

async def _load_entry():
# Mock config entry
async def _load_entry() -> None:
assert await async_setup_component(hass, "test", {})

entry = MockConfigEntry(title="test_title", domain="test")
entry.add_to_hass(hass)
flow = hass.config_entries.flow
with patch.object(flow, "async_init", wraps=flow.async_init):
hass.async_add_job(_load_entry)
hass.async_create_task(_load_entry())
new_state = await hass.config_entries.async_wait_for_states(
entry,
{
Expand All @@ -3367,7 +3365,7 @@ async def _load_entry():
assert entry.state is config_entries.ConfigEntryState.LOADED


async def test_wait_for_loading_failed_entry(hass):
async def test_wait_for_loading_failed_entry(hass: HomeAssistant) -> None:
"""Test waiting for entry to be set up that fails loading."""

entry = MockConfigEntry(title="test_title", domain="test")
Expand All @@ -3376,20 +3374,17 @@ async def test_wait_for_loading_failed_entry(hass):
mock_integration(hass, MockModule("test", async_setup_entry=mock_setup_entry))
mock_entity_platform(hass, "config_flow.test", None)

await entry.async_setup(hass)
await hass.async_block_till_done()

flow = hass.config_entries.flow

async def _load_entry():
# Mock config entry
async def _load_entry() -> None:
assert await async_setup_component(hass, "test", {})

entry = MockConfigEntry(title="test_title", domain="test")
entry.add_to_hass(hass)
flow = hass.config_entries.flow
with patch.object(flow, "async_init", wraps=flow.async_init):
hass.async_add_job(_load_entry)
hass.async_create_task(_load_entry())
new_state = await hass.config_entries.async_wait_for_states(
entry,
{
Expand All @@ -3402,7 +3397,7 @@ async def _load_entry():
assert entry.state is config_entries.ConfigEntryState.SETUP_ERROR


async def test_wait_for_loading_timeout(hass):
async def test_wait_for_loading_timeout(hass: HomeAssistant) -> None:
"""Test waiting for entry to be set up that fails with a timeout."""

async def _async_setup_entry(hass, entry):
Expand All @@ -3414,20 +3409,17 @@ async def _async_setup_entry(hass, entry):
mock_integration(hass, MockModule("test", async_setup_entry=_async_setup_entry))
mock_entity_platform(hass, "config_flow.test", None)

await entry.async_setup(hass)
await hass.async_block_till_done()

flow = hass.config_entries.flow

async def _load_entry():
# Mock config entry
async def _load_entry() -> None:
assert await async_setup_component(hass, "test", {})

entry = MockConfigEntry(title="test_title", domain="test")
entry.add_to_hass(hass)
flow = hass.config_entries.flow
with patch.object(flow, "async_init", wraps=flow.async_init):
hass.async_add_job(_load_entry)
hass.async_create_task(_load_entry())
with pytest.raises(asyncio.exceptions.TimeoutError):
await hass.config_entries.async_wait_for_states(
entry,
Expand Down