Add device tracker for Linksys Smart Wifi devices#8144
Merged
Conversation
Contributor
|
@mortenlj, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob, @fabaff and @happyleavesaoc to be potential reviewers. |
houndci-bot
reviewed
Jun 21, 2017
| }] | ||
| return requests.post('http://{}/JNAP/'.format(self.host), | ||
| timeout=DEFAULT_TIMEOUT, | ||
| headers={"X-JNAP-Action": "http://linksys.com/jnap/core/Transaction"}, |
There was a problem hiding this comment.
line too long (99 > 79 characters)
| for device in devices: | ||
| macs = device["knownMACAddresses"] | ||
| if not macs: | ||
| _LOGGER.warn("Found device without known MAC address, skipping") |
There was a problem hiding this comment.
line too long (88 > 79 characters)
| self.last_results = {} | ||
| response = self._make_request() | ||
| if response.status_code != 200: | ||
| _LOGGER.error("Unable to get device list from router, got HTTP status code %d", response.status_code) |
There was a problem hiding this comment.
line too long (117 > 79 characters)
| raise ConnectionError("Cannot connect to Linksys Access Point") | ||
|
|
||
| def scan_devices(self): | ||
| """Scan for new devices and return a list with found device IDs (MACs).""" |
There was a problem hiding this comment.
line too long (82 > 79 characters)
Merged
dethpickle
pushed a commit
to dethpickle/home-assistant
that referenced
this pull request
Aug 18, 2017
* Add device tracker for Linksys Smart Wifi devices * Fixing code style
ghost
added
integration: linksys_smart
and removed
platform: device_tracker.linksys_smart
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Support for Linksys Smart Wifi devices, which looks like it's going to be all new devices from now on.
I have not had time to add documentation, but I can try to find time to look at that later this week.
Related issue (if applicable): #7487
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#2872
Example entry for
configuration.yaml(if applicable):Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.