Skip to content

Add option to specify the location of the API (fixes #8115)#8118

Merged
pvizeli merged 1 commit into
home-assistant:devfrom
fabaff:pi-hole
Jun 20, 2017
Merged

Add option to specify the location of the API (fixes #8115)#8118
pvizeli merged 1 commit into
home-assistant:devfrom
fabaff:pi-hole

Conversation

@fabaff
Copy link
Copy Markdown
Member

@fabaff fabaff commented Jun 20, 2017

Description:

  • Add new configuration variable location to point to the API location.
  • Introduce available()

Related issue (if applicable): fixes #8115

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#2856

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: pi_hole
    location: pihole

Checklist:

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass

@mention-bot
Copy link
Copy Markdown

@fabaff, thanks for your PR! By analyzing the history of the files in this pull request, we identified @colinodell to be a potential reviewer.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, missed that to remove.

Copy link
Copy Markdown
Member

@pvizeli pvizeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@pvizeli pvizeli merged commit d46607c into home-assistant:dev Jun 20, 2017
@fabaff fabaff deleted the pi-hole branch June 20, 2017 12:28
@balloob balloob mentioned this pull request Jul 1, 2017
dethpickle pushed a commit to dethpickle/home-assistant that referenced this pull request Aug 18, 2017
@home-assistant home-assistant locked and limited conversation to collaborators Oct 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pi-hole sensor doesn't work with installation with custom endpoint

5 participants