Comfoconnect fan component#8073
Merged
Merged
Conversation
|
@michaelarnauts, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fabaff, @balloob and @rmkraus to be potential reviewers. |
a88acf9 to
8e60452
Compare
Contributor
Author
|
There seems to be an unrelated issue failing the CI. |
balloob
reviewed
Jun 24, 2017
| from homeassistant.helpers.dispatcher import (dispatcher_send) | ||
|
|
||
| REQUIREMENTS = [ | ||
| 'https://github.com/michaelarnauts/comfoconnect' |
Member
There was a problem hiding this comment.
Would you be able to push this to Pypi?
Merged
dethpickle
pushed a commit
to dethpickle/home-assistant
that referenced
this pull request
Aug 18, 2017
* Comfoconnect fan component. * Fix linter. Don't store hass object when not needed. * More code style. * Rebase to dev and add to coverage ignore list. * Use published package from pypi.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds support for the Zehnder ComfoAir Q350/450/600 ventilation systems. You'll need a ComfoConnect LAN C bridge to interface with it.
The bridge can report sensor data, and you can adjust the ventilation mode (away, low, medium and high).
It's a rewrite of #7246 and has since been split into a generic
comfoconnectcomponent with a fan platform and an optional sensors platform. You can pass a list of sensors to the sensor platform and it will register with the bridge for those values. The component is now also using the dispatcher helper to communicate to the platforms.If I'm not mistaken, the remarks of #7246 haven been resolved.
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#2483
Example entry for
configuration.yaml(if applicable):Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.