Skip to content

Comfoconnect fan component#8073

Merged
michaelarnauts merged 5 commits into
home-assistant:devfrom
michaelarnauts:comfoconnect
Jun 28, 2017
Merged

Comfoconnect fan component#8073
michaelarnauts merged 5 commits into
home-assistant:devfrom
michaelarnauts:comfoconnect

Conversation

@michaelarnauts
Copy link
Copy Markdown
Contributor

Description:

This PR adds support for the Zehnder ComfoAir Q350/450/600 ventilation systems. You'll need a ComfoConnect LAN C bridge to interface with it.

The bridge can report sensor data, and you can adjust the ventilation mode (away, low, medium and high).

It's a rewrite of #7246 and has since been split into a generic comfoconnect component with a fan platform and an optional sensors platform. You can pass a list of sensors to the sensor platform and it will register with the bridge for those values. The component is now also using the dispatcher helper to communicate to the platforms.

If I'm not mistaken, the remarks of #7246 haven been resolved.

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#2483

Example entry for configuration.yaml (if applicable):

comfoconnect:
  name: ventilation
  host: 192.168.1.213

sensor:
- platform: comfoconnect
  resources:
    - current_temperature
    - current_humidity
    - outside_temperature
    - outside_humidity
#    - air_flow_supply
#    - air_flow_exhaust

Checklist:

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

@mention-bot
Copy link
Copy Markdown

@michaelarnauts, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fabaff, @balloob and @rmkraus to be potential reviewers.

@michaelarnauts
Copy link
Copy Markdown
Contributor Author

There seems to be an unrelated issue failing the CI.

from homeassistant.helpers.dispatcher import (dispatcher_send)

REQUIREMENTS = [
'https://github.com/michaelarnauts/comfoconnect'
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you be able to push this to Pypi?

Copy link
Copy Markdown
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks great. Can be merged when the dependency has been pushed to PyPi (see #7069)

@michaelarnauts michaelarnauts merged commit 5dde0c2 into home-assistant:dev Jun 28, 2017
@balloob balloob mentioned this pull request Jul 1, 2017
dethpickle pushed a commit to dethpickle/home-assistant that referenced this pull request Aug 18, 2017
* Comfoconnect fan component.

* Fix linter. Don't store hass object when not needed.

* More code style.

* Rebase to dev and add to coverage ignore list.

* Use published package from pypi.
@home-assistant home-assistant locked and limited conversation to collaborators Oct 20, 2017
@michaelarnauts michaelarnauts deleted the comfoconnect branch November 16, 2019 14:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants