Skip to content

Bump pyEmby version to account for API changes#8070

Merged
fabaff merged 1 commit into
home-assistant:devfrom
mezz64:emby_1.3
Jun 17, 2017
Merged

Bump pyEmby version to account for API changes#8070
fabaff merged 1 commit into
home-assistant:devfrom
mezz64:emby_1.3

Conversation

@mezz64
Copy link
Copy Markdown
Contributor

@mezz64 mezz64 commented Jun 17, 2017

Description:

Emby is going through some codebase changes that are altering the API. This PR accounts for a key change that was breaking things on the latest version. Code fix is backwards compatible.

Checklist:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.

@mention-bot
Copy link
Copy Markdown

@mezz64, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob, @fabaff and @rmkraus to be potential reviewers.

@pvizeli
Copy link
Copy Markdown
Member

pvizeli commented Jun 17, 2017

Your coverage is to bad. Maby a rebase helps here?

Copy link
Copy Markdown
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

@fabaff fabaff merged commit 33d3817 into home-assistant:dev Jun 17, 2017
@balloob balloob mentioned this pull request Jul 1, 2017
@mezz64 mezz64 deleted the emby_1.3 branch July 4, 2017 05:43
@home-assistant home-assistant locked and limited conversation to collaborators Oct 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants