Allow config of latitude and longitude#8068
Merged
fabaff merged 1 commit intoJun 17, 2017
Merged
Conversation
This will allow for dynamically updating weather states, for instance if you wanted to use the latitude and longitude of a phone or other device to get the weather for your current location.
Contributor
|
Hi @jshore1296, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
|
@jshore1296, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fabaff, @tchellomello and @arsaboo to be potential reviewers. |
Contributor
Author
|
I am brand new to contributing here - and I'm not familiar with how tests work in this repository yet. Any guidance you have would be greatly appreciated! Bear with me, haha! I'll do my best to be cooperative and helpful. |
Merged
ghost
added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow for dynamically updating weather states using the WUnderground
API, for instance if you wanted to use the latitude and longitude of a phone
or other device to get the weather for your current location.
Description:
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#2829
Example entry for
configuration.yaml(if applicable):Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass