Fix attribute entity#8066
Merged
Merged
Conversation
|
@pvizeli, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob, @robbiet480 and @Diaoul to be potential reviewers. |
balloob
reviewed
Jun 17, 2017
| self.assertIsNone(state.attributes.get('white_value')) | ||
| self.assertIsNone(state.attributes.get('xy_color')) | ||
| self.assertIsNone(state.attributes.get(ATTR_ASSUMED_STATE)) | ||
| self.assertFalse(state.attributes.get(ATTR_ASSUMED_STATE)) |
Member
There was a problem hiding this comment.
We should not add assumed state. I guess we should have assumed_state default to return None
Member
Author
There was a problem hiding this comment.
@balloob done. The problem is, if a device support assume_state it will be present but on a device without that implement it will not present. I think that is correct.
2 tasks
Member
|
Cherry-picked for 0.47 |
balloob
pushed a commit
that referenced
this pull request
Jun 17, 2017
* Bugfix entity attribute setter * Fix tests * Fix tests part 2 * Change filter only None * Fix tests part 3 * Update entity.py * Fix tests
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Fix a bug that attribute entity not present if they is
Falseor0If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass