Skip to content

Allow to cast in HLS format when using WebRTC #80646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
balloob merged 1 commit into from
Oct 26, 2022
Merged

Allow to cast in HLS format when using WebRTC #80646

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions homeassistant/components/camera/media_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,15 +46,17 @@ async def async_resolve_media(self, item: MediaSourceItem) -> PlayMedia:
f"/api/camera_proxy_stream/{camera.entity_id}", camera.content_type
)

if stream_type != StreamType.HLS:
raise Unresolvable("Camera does not support MJPEG or HLS streaming.")

if "stream" not in self.hass.config.components:
raise Unresolvable("Stream integration not loaded")

try:
url = await _async_stream_endpoint_url(self.hass, camera, HLS_PROVIDER)
Copy link
Copy Markdown
Member

@balloob balloob Oct 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm on my phone, what does the error handling do here?

Copy link
Copy Markdown
Contributor Author

@felipecrs felipecrs Oct 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose it was meant to return a meaningful message to end-user (which this PR keeps).

except HomeAssistantError as err:
# Handle known error
if stream_type != StreamType.HLS:
raise Unresolvable(
"Camera does not support MJPEG or HLS streaming."
) from err
raise Unresolvable(str(err)) from err

return PlayMedia(url, FORMAT_CONTENT_TYPE[HLS_PROVIDER])
Expand Down