Added 'all_plants' group and support for plant groups state.#8063
Merged
Conversation
balloob
approved these changes
Jun 17, 2017
Member
|
Cherry-picked for 0.47 |
balloob
pushed a commit
that referenced
this pull request
Jun 17, 2017
* Added 'all_plants' group and support for plant groups state. * Reversed the group states.
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Like switches, lights, and devices, plants deserve a group of their own! Here, I added the group
all_plants, usingEntityComponent's built-in functionality.Additionally, I created the
STATE_OKandSTATE_PROBLEMstates, and introduced them into the group component - so that a group of plants can show theSTATE_PROBLEMstate whenever one of its plants has a problem. Great for automations!Checklist:
If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass