Skip to content

Failed to parse response from WU API: 'record' (and 'recordyear') #7747#8058

Merged
fabaff merged 1 commit into
home-assistant:devfrom
pezinek:wu
Jun 17, 2017
Merged

Failed to parse response from WU API: 'record' (and 'recordyear') #7747#8058
fabaff merged 1 commit into
home-assistant:devfrom
pezinek:wu

Conversation

@pezinek
Copy link
Copy Markdown
Contributor

@pezinek pezinek commented Jun 16, 2017

Description:

Changes errors to warning when there are data missing in the WU API response.

Related issue (if applicable): fixes #7747

Pull request in home-assistant.github.io with documentation (if applicable): N/A

Checklist:

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

Note: tests not added as there isn't really anything to test.

@mention-bot
Copy link
Copy Markdown

@pezinek, thanks for your PR! By analyzing the history of the files in this pull request, we identified @arsaboo, @Teagan42 and @tchellomello to be potential reviewers.

Copy link
Copy Markdown
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🐦

@fabaff fabaff merged commit 7617864 into home-assistant:dev Jun 17, 2017
@balloob balloob mentioned this pull request Jul 1, 2017
@home-assistant home-assistant locked and limited conversation to collaborators Oct 20, 2017
@pezinek pezinek deleted the wu branch October 23, 2017 22:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failed to parse response from WU API: 'record' (and 'recordyear')

5 participants