media player Kodi: handle TransportError exceptions when calling JSONRPC API methods#8047
Merged
Conversation
houndci-bot
reviewed
Jun 15, 2017
| _LOGGER.info("TransportError trying to add playlist", | ||
| self.entity_id) | ||
| _LOGGER.debug("TransportError trying to add playlist", | ||
| self.entity_id, exc_info = True) |
There was a problem hiding this comment.
unexpected spaces around keyword / parameter equals
pvizeli
requested changes
Jun 15, 2017
| _LOGGER.info("TransportError trying to run API method %s.%s(%s)", | ||
| self.entity_id, method, kwargs) | ||
| _LOGGER.debug("TransportError trying to run API method %s.%s(%s)", | ||
| self.entity_id, method, kwargs, exc_info=True) |
Member
There was a problem hiding this comment.
Use only one logging call -> warning
Member
Author
There was a problem hiding this comment.
Done (removed exc_info in debug level)
| _LOGGER.info("TransportError trying to add playlist to %s", | ||
| self.entity_id) | ||
| _LOGGER.debug("TransportError trying to add playlist to %s", | ||
| self.entity_id, exc_info=True) |
Member
There was a problem hiding this comment.
Use only one logging call -> warning
Member
Author
There was a problem hiding this comment.
Done (removed exc_info in debug level)
pvizeli
approved these changes
Jun 16, 2017
Member
Author
|
Hi @pvizeli, the Travis CI build timed out ¿?, could you restart it to try again? |
Merged
ghost
added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Handle TransportError exceptions when calling JSONRPC API services. This exception raises when Kodi is not present or there is a problem in the websocket connection.
Example entry for
configuration.yaml(if applicable):