Fixed the Wind sensor following new release of netatmo-api-python#8030
Conversation
The NetAtmo PR was at: jabesq/netatmo-api-python#5 Essentially, this commit adds a protection when adding an incorrect monitored conditions to avoid to fail the entire NetAtmo component, plus for consistency reasons all conditions are now in lower case.
|
Hi @glpatcern, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
homeassistant
added
cla-needed
integration: netatmo
merging-to-master
|
@glpatcern, thanks for your PR! By analyzing the history of the files in this pull request, we identified @HydrelioxGitHub, @jabesq and @fabaff to be potential reviewers. |
| if variable in SENSOR_TYPES.keys(): | ||
| dev.append(NetAtmoSensor(data, module_name, variable)) | ||
| else: | ||
| _LOGGER.warning("Ignoring unknown var %s for mod %s", \ |
There was a problem hiding this comment.
the backslash is redundant between brackets
|
You deleted the instruction to run |
pvizeli
removed
the
merging-to-master
|
Hi Paulus, sure - I thought the other instructions were not relevant but anyway I applied the required changes to hopefully get CI to pass. |
|
...which now fails on a different unrelated place, where it was passing before. As far as I can see, the PR is clear, but please advice. |
|
Awesome, thanks 👍 |
|
You're welcome! Glad to have contributed to this project, and I expect some more contributions in the near future... |
ghost
removed
the
7 participants
Description:
The Wind NetAtmo sensor was unsupported and effectively broken so far.
Essentially, this commit adds a protection when adding incorrect monitored conditions to avoid to fail the entire NetAtmo component. Moreover for consistency reasons all conditions are renamed to lower case.
The real fix comes with python-netatmo-api 0.9.2, merged PR at:
jabesq/netatmo-api-python#5
No user configuration is changed by this patch. I did not run any integration test yet, I guess this will come by the PR itself. Obviously, "it works for me", but I'm available to execute any test as required.