Fix some warnings found by quantifiedcode#8027
Conversation
| # discovery.load_platform(hass, 'light', DOMAIN, {}, config) | ||
|
|
||
| return True | ||
| # return True |
There was a problem hiding this comment.
You can not comment out this code on insteon_hub
There was a problem hiding this comment.
Al lthis code is unreachable due to return False above.
There was a problem hiding this comment.
I don't see a benefit for do that and also why we should produce a precidence case with it
There was a problem hiding this comment.
Delete the hole component are better as comment out that stuff.
There was a problem hiding this comment.
I would prefer if we just don't touch this file. If anything, just add a comment to disable the Quantified Code warning.
There was a problem hiding this comment.
Although I guess we can also just remove it all.
|
I think the change are legitime until that one with comment a lot of lines out see comments above. |
|
I deleted the instean_hub component. |
ghost
added
4 participants
Description:
If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass