media_player.firetv - Adding support for https.#8022
Merged
Conversation
This change allows to access a firetv-server instance that runs over https (via a reverse proxy for exemple). Default stays http, but if `ssl: true` is set in the configuration the connection goes over https. Successfully tested.
Contributor
houndci-bot
reviewed
Jun 13, 2017
| try: | ||
| requests.get(DEVICE_ACTION_URL.format( | ||
| self.host, self.port, self.device_id, action_id), timeout=10) | ||
| self.proto, self.host, self.port, self.device_id, action_id), timeout=10) |
There was a problem hiding this comment.
line too long (89 > 79 characters)
| response = requests.get( | ||
| DEVICE_STATE_URL.format( | ||
| self.host, self.port, self.device_id), timeout=10).json() | ||
| self.proto, self.host, self.port, self.device_id), timeout=10).json() |
There was a problem hiding this comment.
line too long (89 > 79 characters)
|
|
||
| try: | ||
| response = requests.get(DEVICE_LIST_URL.format(host, port)).json() | ||
| response = requests.get(DEVICE_LIST_URL.format(proto, host, port)).json() |
There was a problem hiding this comment.
line too long (81 > 79 characters)
| from homeassistant.const import ( | ||
| STATE_IDLE, STATE_OFF, STATE_PAUSED, STATE_PLAYING, STATE_STANDBY, | ||
| STATE_UNKNOWN, CONF_HOST, CONF_PORT, CONF_NAME, CONF_DEVICE, CONF_DEVICES) | ||
| STATE_UNKNOWN, CONF_HOST, CONF_PORT, CONF_SSL, CONF_NAME, CONF_DEVICE, CONF_DEVICES) |
There was a problem hiding this comment.
line too long (88 > 79 characters)
Contributor
|
Looks good once lint errors are fixed! |
Contributor
Author
|
I have set up a proper developement environment now. Lint errors are fixed. |
balloob
approved these changes
Jun 16, 2017
Merged
ghost
added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows to access a firetv-server instance that runs over https (behind reverse proxy for exemple).
Default stays http, but if
ssl: trueis set in the configuration the connection goes over https.Full configuration exemple:
Successfully tested.