add knx cover support#7997
Merged
Merged
Conversation
also corrected bugs in device config 1. overwriting of addresses in KNXMultiAddressDevice 2. setting and getting int values 3. added percentage scaling
Contributor
Contributor
Author
|
It's my first time to make a PR for the project. If I need to do something else to get this change considered for review/merging could someone give me a hint? |
balloob
approved these changes
Jun 19, 2017
Member
balloob
left a comment
There was a problem hiding this comment.
This is awesome. Looks all great 🐬 🎉
I removed the property device_class that you added to the cover entity, as it's already party of the entity base class.
Merged
dethpickle
pushed a commit
to dethpickle/home-assistant
that referenced
this pull request
Aug 18, 2017
* add knx cover also corrected bugs in device config 1. overwriting of addresses in KNXMultiAddressDevice 2. setting and getting int values 3. added percentage scaling * Update __init__.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for KNX covers (roller shutters, window blinds)
Description:
Related feature request: https://community.home-assistant.io/t/support-for-knx-shutters-position-stop/14142
Notes
Tested with MDT roller shutter. This hardware uses 0 as open and 100 as closed, which is the opposite of the base cover implementation. This problem is mentioned here, which appeared to suggest that the polymer frontend would automatically reverse the definition of open/closed based on the device class so I also added optional support for the "device_class" setting. When I tested that locally it did not appear to work (although the icon did change)
The KNXMultiAddressDevice storage of address names was also changed from class storage to object instance storage because the same address names are used for object instance so the values were being overwritten.
Needed to add calls supporting percentage type DPT_Scaling used for KNX position values in cover devices
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#2845
Example entry for
configuration.yaml(if applicable):Checklist:
Note: no new dependencies, tests pass. Lint and pydoc warnings from tox have been corrected in the updated files
If user exposed functionality or configuration variables are added/changed:
Documentation added/updated in home-assistant.github.io
Local tests with
toxrun successfully. Your PR cannot be merged unless tests passNew dependencies have been added to the
REQUIREMENTSvariable (example).New dependencies are only imported inside functions that use them (example).
New dependencies have been added to
requirements_all.txtby runningscript/gen_requirements_all.py.New files were added to
.coveragerc.