Migrate the LIFX integration to use kelvin for color temp#79775
Conversation
Signed-off-by: Avi Miller <me@dje.li>
|
Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( |
|
Nice. That was quick. I'll give this a spin this weekend |
|
I've been wanting this for longer than I've been a contributor to Home Assistant. 😂 |
|
This may be further weirdness with how the Either way, I have plenty of Beams lying around, so I'll test it now and work it out. |
|
I can't reproduce this on my Beams: they remain the same temperature through on/off cycles. |
Signed-off-by: Avi Miller <me@dje.li>
|
I forgot to move the check for color temp changes back to after hue/saturation changes while I was working out an issue with getting the wrong kelvin value. Not sure if it's related to your issue though. And I'm now trying to work out how to extend the UI so that it covers the entire kelvin range available to LIFX devices (1500-9000) instead of being stuck with the more limited 2000-6535 provided now. |
Interesting. There are two Beams on the product list, one that goes to 1500K, the other only to 2500K. I'll double-check to make sure that the |
bdraco
left a comment
There was a problem hiding this comment.
The above issue is unrelated to this PR.
So this LGTM 👍



Proposed change
Switch the LIFX integration to use kelvin for color temperature values.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: