Add initial support for Shiftr.io#7974
Conversation
|
Only small mods required for posting to Initial State |
pvizeli
left a comment
There was a problem hiding this comment.
I don't sure if we should use our internal mqtt server object. They is also connect to dispatcher and that do not check from where the data a are comming. I think that is a bit a security hole.
Maby with a own paho client or hbmqtt we are better and any future change on our internal mqtt server object will not affect shiftr negative?
|
|
||
| mqttc = mqtt.Client(client_id, protocol=mqtt.MQTTv311) | ||
| mqttc.username_pw_set(username, password=password) | ||
| mqttc.connect(SHIFTR_BROKER, port=port, keepalive=keepalive) |
There was a problem hiding this comment.
I think that need inside a yield from hass.async_add_job() to not block the loop.
|
Thanks for the update. The idea was to use the internal MQTT object to be async but I will work that way too. |
Description:
This component simply make the events from Home Assistant available in the communication infrastructure on shiftr.io. This allows one to share data and see the flows in a realtime graph that visualizes all events happening in a namespace.
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#2827
Example entry for
configuration.yaml(if applicable):Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable ([example][ex-requir]).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.