Skip to content

Fix Met Office Sensor#7965

Merged
balloob merged 1 commit into
home-assistant:devfrom
girlpunk:dev
Jun 9, 2017
Merged

Fix Met Office Sensor#7965
balloob merged 1 commit into
home-assistant:devfrom
girlpunk:dev

Conversation

@girlpunk
Copy link
Copy Markdown
Contributor

@girlpunk girlpunk commented Jun 8, 2017

Description:

Fixes the Met Office sensor issues raised at https://community.home-assistant.io/t/metoffice-integration/15537. No new dependencies or files.

Related issue (if applicable): fixes https://community.home-assistant.io/t/metoffice-integration/15537

Pull request in home-assistant.github.io with documentation (if applicable): N/A, no configuration changes

Checklist:

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

Fix met office sensor
@mention-bot
Copy link
Copy Markdown

@cyberjacob, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jacobtomlinson and @fabaff to be potential reviewers.

@balloob
Copy link
Copy Markdown
Member

balloob commented Jun 9, 2017

Thanks!

Cherry-picked for 0.46.1

@balloob balloob merged commit 24a1721 into home-assistant:dev Jun 9, 2017
balloob pushed a commit that referenced this pull request Jun 9, 2017
Fix met office sensor
@balloob balloob mentioned this pull request Jun 9, 2017
@balloob balloob mentioned this pull request Jun 16, 2017
@home-assistant home-assistant locked and limited conversation to collaborators Oct 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants