Skip to content

Ripple sensor#7935

Merged
fabaff merged 1 commit into
home-assistant:devfrom
nkgilley:ripple
Jun 7, 2017
Merged

Ripple sensor#7935
fabaff merged 1 commit into
home-assistant:devfrom
nkgilley:ripple

Conversation

@nkgilley
Copy link
Copy Markdown
Contributor

@nkgilley nkgilley commented Jun 6, 2017

Description:

Ripple.com cryptocurrency sensor

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#2781

Example entry for configuration.yaml (if applicable):

sensor:
  platform: ripple
  address: 'r3kmLJN5D28dHuH8vZNUZpMC43pEHpaocV'

Checklist:

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

@mention-bot
Copy link
Copy Markdown

@nkgilley, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob, @fabaff and @robbiet480 to be potential reviewers.

@nkgilley nkgilley changed the title add ripple sensor Ripple sensor Jun 6, 2017
Copy link
Copy Markdown
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🐦

@fabaff fabaff merged commit b87e316 into home-assistant:dev Jun 7, 2017
@balloob balloob mentioned this pull request Jun 16, 2017
@home-assistant home-assistant locked and limited conversation to collaborators Oct 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants