Fixed openhome metadata issue#7932
Merged
Merged
Conversation
|
@bazwilliams, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob and @fabaff to be potential reviewers. |
houndci-bot
reviewed
Jun 6, 2017
houndci-bot
reviewed
Jun 6, 2017
There was a problem hiding this comment.
continuation line with same indent as next logical line
d7691ef to
cc4bcc5
Compare
pvizeli
requested changes
Jun 8, 2017
14cd30d to
3f9b16e
Compare
balloob
approved these changes
Jun 9, 2017
Member
|
Cherry-picked for 0.46.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
A change in the openhomedevice library now means some metadata might not be present when requesting track information. I forgot to defend against this and as a result when the metadata is not present an key exception is thrown.
This also stops devices from being registered on discovery due to the call of 'update' when adding.
Related issue (if applicable): fixes #7926
Checklist:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable ([example][ex-requir]).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.