Update pyunifi component to use APIError passed from pyunifi 2.13. Better accommodate login failures with wrapper in pyunifi 2.13.

[finish06]

Description:

Added wrapper to pyunifi 2.13 '_read' function to improve handling of authentication related failures. Updated unifi component to accept 'APIError' as passed from pyunifi. Adjusted urllib3.exceptions.InsecureRequestWarning to display a single time.

Checklist:

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

• Local tests with tox run successfully. Your PR cannot be merged unless tests pass
• New dependencies have been added to the REQUIREMENTS variable (example).
• New dependencies are only imported inside functions that use them (example).
• New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
• New files were added to .coveragerc.

If the code does not interact with devices:

• Local tests with tox run successfully. Your PR cannot be merged unless tests pass
• Tests have been added to verify that the new code works.

[houndci-bot]

undefined name 'APIError'

[houndci-bot]

undefined name 'APIError'

[balloob]

You'll need to import APIError first.

[finish06]

In need of assistance regarding updating the test_unifi.py file. Thanks!

[balloob]

Add pyunify to https://github.com/home-assistant/home-assistant/blob/dev/script/gen_requirements_all.py#L34 and then rerun it and commit the changed files.

[balloob]

Please remove this file.

[balloob]

@finish06 please make sure that APIError extends Exception:

class APIError(Exception):
    """Base class for unifi errors."""
    pass

[finish06]

@balloob I definitely have it setup in the manner you recommend. The error still occurs even though 'APIError' is a child of 'Exception'.

[balloob]

Ooooooooooooooooooooh I get it. The old unifi tests were mocking out the unify lib: https://github.com/home-assistant/home-assistant/blob/dev/tests/components/device_tracker/test_unifi.py#L13-L20

[finish06]

@balloob alright, I am glad you had a eureka, however, my naivety prevents me from understanding what the implications of the new insight... I know that adding from pyunifi import controller which I thought would being that the fixture needs that imported (or so I thought).

[balloob]

That fixture patches the imported modules to always load a fake one. You can remove it and instead make sure that the controller is still mocked and returned from the fixture.

[balloob]

I tried something, not sure if it will work.

[balloob]

Cherry-picked for 0.47 👍