Add support for the expirationTime parameter in html5 subscriptions#7895
Merged
Conversation
|
@perosb, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob, @robbiet480 and @capellini to be potential reviewers. |
houndci-bot
reviewed
Jun 4, 2017
houndci-bot
reviewed
Jun 4, 2017
Enabled by default in Chrome 60. Only accepts the param, doesn't act on the actual expiration date. Chrome will always pass NULL for now. w3c/push-api#248 https://www.chromestatus.com/feature/4929396687241216 https://bugs.chromium.org/p/chromium/issues/detail?id=718837
Member
|
Thanks! |
Merged
ghost
added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This parameter is enabled by default in Chrome 60.
Only accepts the param, doesn't act on the actual expiration date. Chrome will always pass NULL for now.
w3c/push-api#248
https://www.chromestatus.com/feature/4929396687241216
https://bugs.chromium.org/p/chromium/issues/detail?id=718837
Description:
Checklist:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passIf the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass