Skip to content

Use constants#7888

Merged
fabaff merged 1 commit into
home-assistant:devfrom
fabaff:consts-xmpp
Jun 3, 2017
Merged

Use constants#7888
fabaff merged 1 commit into
home-assistant:devfrom
fabaff:consts-xmpp

Conversation

@fabaff
Copy link
Copy Markdown
Member

@fabaff fabaff commented Jun 3, 2017

Description:

Use constants.

Example entry for configuration.yaml (if applicable):

notify:
  - platform: xmpp
    name: jabber
    sender: !secret xmpp_sender
    password: !secret xmpp_password
    recipient: !secret xmpp_recipient

Checklist:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass

@mention-bot
Copy link
Copy Markdown

@fabaff, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob, @pvizeli and @MartinHjelmare to be potential reviewers.

@fabaff fabaff merged commit cf1a27b into home-assistant:dev Jun 3, 2017
@fabaff fabaff deleted the consts-xmpp branch June 3, 2017 20:33
@balloob balloob mentioned this pull request Jun 16, 2017
@home-assistant home-assistant locked and limited conversation to collaborators Sep 4, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants