lock.sesame: Add support for Sesame smart locks by trisk · Pull Request #7873 · home-assistant/core

trisk · 2017-06-03T00:59:30Z

Description:

Add support for Sesame smart locks, by CANDY HOUSE.

Add platform to support the new Sesame cloud API
Enumerates all available Sesame devices

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#2743

Example entry for `configuration.yaml` (if applicable):

# Example configuration.yaml entry
lock:
  - platform: sesame
    email: abc@i-lovecandyhouse.co
    password: super-strong-password

homeassistant · 2017-06-03T00:59:32Z

Hi @trisk,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

mention-bot · 2017-06-03T00:59:33Z

@trisk, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob, @fabaff and @happyleavesaoc to be potential reviewers.

houndci-bot · 2017-06-03T00:59:36Z

continuation line over-indented for visual indent

houndci-bot · 2017-06-03T00:59:36Z

line too long (82 > 79 characters)

houndci-bot · 2017-06-03T00:59:36Z

continuation line under-indented for visual indent

houndci-bot · 2017-06-03T01:09:32Z

continuation line with same indent as next logical line

trisk · 2017-06-03T01:23:34Z

Lock/unlock actions are not completely tested until I have the Wi-Fi Access Point hardware. Right now the API calls seem to produce the correct responses.

philhawthorne · 2017-06-03T05:59:32Z

@trisk well done!

I am also awaiting for the Wifi Access Point. Good to see Home Assistant will support Sesame as soon as they ship!

balloob · 2017-06-03T06:56:36Z

Please extract platform specific code into a third party lib.

Done, created https://github.com/trisk/pysesame/ and published to PyPI.

houndci-bot · 2017-06-04T03:01:29Z

expected 2 blank lines, found 1

houndci-bot · 2017-06-04T03:01:29Z

'requests' imported but unused

* Manage Sesame devices through CANDY HOUSE's cloud API * Add dependency on new pysesame library

balloob

Perfect! 🐬

homeassistant added new-platform platform: lock.sesame cla-needed labels Jun 3, 2017

houndci-bot reviewed Jun 3, 2017

View reviewed changes

homeassistant added cla-signed and removed cla-needed labels Jun 3, 2017

trisk mentioned this pull request Jun 3, 2017

New lock platform for Sesame smart locks home-assistant/home-assistant.io#2743

Merged

trisk force-pushed the sesame branch from 7dd2feb to 6031d85 Compare June 3, 2017 01:09

homeassistant added the cla-signed label Jun 3, 2017

balloobbot added the platform label Jun 3, 2017

houndci-bot reviewed Jun 3, 2017

View reviewed changes

Comment thread homeassistant/components/lock/sesame.py Outdated

Copy link
Copy Markdown

houndci-bot Jun 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

continuation line with same indent as next logical line

trisk force-pushed the sesame branch from 6031d85 to 88533bb Compare June 3, 2017 01:12

homeassistant added the cla-signed label Jun 3, 2017

trisk force-pushed the sesame branch from 88533bb to f6565c8 Compare June 3, 2017 01:21

homeassistant added the cla-signed label Jun 3, 2017

trisk force-pushed the sesame branch from f6565c8 to 426fe3b Compare June 3, 2017 01:38

homeassistant added the cla-signed label Jun 3, 2017

balloob requested changes Jun 3, 2017

View reviewed changes

trisk force-pushed the sesame branch from 426fe3b to f707b12 Compare June 4, 2017 03:01

homeassistant added the cla-signed label Jun 4, 2017

houndci-bot reviewed Jun 4, 2017

View reviewed changes

trisk force-pushed the sesame branch from f707b12 to bbbe0c6 Compare June 4, 2017 03:29

homeassistant added the cla-signed label Jun 4, 2017

balloobbot added the requirement label Jun 4, 2017

homeassistant added the cla-signed label Jun 4, 2017

lock.sesame: New lock platform for Sesame smart locks

837978a

* Manage Sesame devices through CANDY HOUSE's cloud API * Add dependency on new pysesame library

trisk force-pushed the sesame branch from 3fd5e91 to 837978a Compare June 4, 2017 10:30

homeassistant added the cla-signed label Jun 4, 2017

balloob approved these changes Jun 5, 2017

View reviewed changes

balloob merged commit aeb1d3d into home-assistant:dev Jun 5, 2017

balloob mentioned this pull request Jun 16, 2017

0.47 #8055

Merged

home-assistant locked and limited conversation to collaborators Sep 4, 2017

ghost added integration: sesame and removed platform: lock.sesame labels Mar 21, 2019

Uh oh!

Conversation

trisk commented Jun 3, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description:

Example entry for configuration.yaml (if applicable):

Uh oh!

homeassistant commented Jun 3, 2017

Uh oh!

mention-bot commented Jun 3, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

trisk commented Jun 3, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

philhawthorne commented Jun 3, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

balloob left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

trisk commented Jun 3, 2017 •

edited

Loading

Example entry for `configuration.yaml` (if applicable):

trisk commented Jun 3, 2017 •

edited

Loading