Rename time trigger 'after' to 'at'

[emlove]

Description:

This PR renames the time trigger 'after' option to 'at'.

In #7556, implemented with #7651, we decided it's too confusing to try and force the trigger configuration names to match the condition names. Similarly, 'after' as a trigger name isn't exactly intuitive. This PR proposes to change it to 'at'. I'm also open to other ideas for the name if someone has a better idea, but it should at least be better than 'after'.

CC @amelchio

Breaking change
For time triggers, after is deprecated and replaced with at.

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#2731

Example entry for configuration.yaml (if applicable):

automation:
  trigger:
    platform: time
    at: '15:32:00'

[mention-bot]

@armills, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob, @fabaff and @robbiet480 to be potential reviewers.

[amelchio]

I agree, it's confusing. Typing after makes me wonder "how long after?"

If we want to clean up all of these, maybe #7170 should be considered at the same time?

[emlove]

Ah, good catch. I agree with that as well. I'll try and get out a PR today, since it would be nice if we could get all of our trigger refactoring into 0.46. Should just be a matter of fixing here: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/helpers/condition.py#L169-L173

[emlove]

Can we think of a use case that would require the old logic? I'm wondering if we should also include the keywords min and max that replicate the existing logic, making both options available. I can't think of anything off the top of my head, but when it comes to floating points sometimes it's the desired behavior and not cleanly replicated otherwise.

[amelchio]

I have that same feeling but cannot think of an example off the top of my head.

[emlove]

Opened #7857 for discussion.

[RiRomain]

Did you leave backward compatibility? Supporting at and after would be nice, at least for a few revision, this will break too much configuration and to handle both keyword it mustn't be too hard, or?

[balloob]

Read either the PR description or the code…

[emlove]

@RiRomain Yes, there is currently backward compatibility. A warning will be issued in the logs if the old name is detected.

[RiRomain]

@balloob I did, didn't see any mention about a backward compatibility but rather a "breaking change".

@armills Ok, thanks for the reply and for the change, it does make the trigger simpler to apprehend :-)

[arsaboo]

@RiRomain It is mentioned right the description

For time triggers, after is deprecated and replaced with at.