Skip to content

Allow 'base_url' (fixes #7784) #7796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
balloob merged 1 commit into from
May 31, 2017
Merged

Allow 'base_url' (fixes #7784) #7796

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions homeassistant/components/upnp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
"""
This module will attempt to open a port in your router for Home Assistant.

For more details about UPnP, please refer to the documentation at
For more details about this component, please refer to the documentation at
https://home-assistant.io/components/upnp/
"""
import logging
from urllib.parse import urlsplit

import voluptuous as vol

Expand Down Expand Up @@ -32,11 +33,15 @@ def setup(hass, config):
try:
upnp.selectigd()
except Exception:
_LOGGER.exception("Error when attempting to discover a UPnP IGD")
_LOGGER.exception("Error when attempting to discover an UPnP IGD")
return False

upnp.addportmapping(hass.config.api.port, 'TCP', hass.config.api.host,
hass.config.api.port, 'Home Assistant', '')
base_url = urlsplit(hass.config.api.base_url)
host = base_url.hostname
external_port = internal_port = base_url.port

upnp.addportmapping(
external_port, 'TCP', host, internal_port, 'Home Assistant', '')

def deregister_port(event):
"""De-register the UPnP port mapping."""
Expand Down