Rest notify data#7757
Merged
Merged
Conversation
added 2 commits
May 24, 2017 16:27
houndci-bot
reviewed
May 24, 2017
| vol.Optional(CONF_DATA, | ||
| default=None): dict, | ||
| vol.Optional(CONF_DATA_TEMPLATE, | ||
| default=None): { cv.match_all: cv.template_complex } |
There was a problem hiding this comment.
whitespace after '{'
whitespace before '}'
Member
|
Should we make the |
Contributor
Author
|
Wouldn't be a bad idea.. I can get to it later
…On Thu, May 25, 2017 at 11:39 AM, Martin Hjelmare ***@***.***> wrote:
Should we make the _data_template_creator a public template helper
function? I know it's used in the service helper module too at least.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7757 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AC2fZTNF6c8U5j0ZJLcZTBt7a1CsVMxMks5r9bzZgaJpZM4Nlv4g>
.
|
Member
|
Yeah, good to make that another PR. This one looks good! |
MartinHjelmare
approved these changes
May 27, 2017
fabaff
approved these changes
May 29, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Add ability to push extra data to the rest notification component
Related issue (if applicable): fixes #
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#2708
Example entry for
configuration.yaml(if applicable):Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable ([example][ex-requir]).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass