Ensure https base_url in telegram bot#7726
Merged
Merged
Conversation
Contributor
Member
|
I've seen this problem too. I think that some components want the base URL to not contain the |
Member
|
I think in this case it would be better to add a way to use a own URL. So if that is not set it use base url. Can you change that? So you can use hass on port 8123 with base_url but add a portforwarding on external with telegran bot. @MartinHjelmare no that have no affect also not with TTS |
balloob
approved these changes
May 23, 2017
Member
balloob
left a comment
There was a problem hiding this comment.
People set their base_url in the http component config. So here we should just use that to make sure that a user is not assuming it will work without https.
This is great 🐬 👍
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
While attempting to resolve a telegram issue I ran into an issue where the base_url was not HTTPS. Added logging to help track down potential issues.