Skip to content

Ensure https base_url in telegram bot#7726

Merged
balloob merged 1 commit into
home-assistant:devfrom
bzillins:beta/telegram
May 23, 2017
Merged

Ensure https base_url in telegram bot#7726
balloob merged 1 commit into
home-assistant:devfrom
bzillins:beta/telegram

Conversation

@bzillins
Copy link
Copy Markdown
Contributor

Description:

While attempting to resolve a telegram issue I ran into an issue where the base_url was not HTTPS. Added logging to help track down potential issues.

@mention-bot
Copy link
Copy Markdown

@bzillins, thanks for your PR! By analyzing the history of the files in this pull request, we identified @sander76, @azogue and @fabaff to be potential reviewers.

@homeassistant
Copy link
Copy Markdown
Contributor

Hi @bzillins,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@MartinHjelmare
Copy link
Copy Markdown
Member

I've seen this problem too. I think that some components want the base URL to not contain the https:// part though. TTS perhaps? We should make sure that no components or platforms have conflicting ideas of how the base URL should be constituted.

@pvizeli
Copy link
Copy Markdown
Member

pvizeli commented May 23, 2017

I think in this case it would be better to add a way to use a own URL. So if that is not set it use base url. Can you change that? So you can use hass on port 8123 with base_url but add a portforwarding on external with telegran bot.

@MartinHjelmare no that have no affect also not with TTS

Copy link
Copy Markdown
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

People set their base_url in the http component config. So here we should just use that to make sure that a user is not assuming it will work without https.

This is great 🐬 👍

@balloob balloob merged commit 228fb8c into home-assistant:dev May 23, 2017
@balloob balloob mentioned this pull request Jun 2, 2017
@home-assistant home-assistant locked and limited conversation to collaborators Sep 4, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants