Skip to content

Updater improvements to send option component information#7720

Merged
balloob merged 4 commits into
home-assistant:devfrom
infamy:updater
Jun 16, 2017
Merged

Updater improvements to send option component information#7720
balloob merged 4 commits into
home-assistant:devfrom
infamy:updater

Conversation

@infamy
Copy link
Copy Markdown
Contributor

@infamy infamy commented May 22, 2017

Description:

Related issue (if applicable): fixes #
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#2698

Example entry for configuration.yaml (if applicable):

updater:
  share_components_info: true

Checklist:

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@homeassistant
Copy link
Copy Markdown
Contributor

Hi @infamy,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

infamy added a commit to home-assistant/home-assistant.io that referenced this pull request May 23, 2017
Updater improvements to send option component information, home-assistant/core#7720
@robbiet480
Copy link
Copy Markdown
Contributor

i see the component data

Copy link
Copy Markdown
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine. I guess we can merge it since it's optional. Merging now means part of release 0.47

@balloob balloob merged commit 437ddb8 into home-assistant:dev Jun 16, 2017
balloob pushed a commit to home-assistant/home-assistant.io that referenced this pull request Jun 16, 2017
* Updater improvements to send option component information

Updater improvements to send option component information, home-assistant/core#7720

* Update updater.markdown
@balloob balloob mentioned this pull request Jun 16, 2017
@home-assistant home-assistant locked and limited conversation to collaborators Oct 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants