Sort entities in default groups by name#7681
Merged
Merged
Conversation
balloob
reviewed
May 21, 2017
|
|
||
| This method must be run in the event loop. | ||
| """ | ||
| def sorted_ids(): |
Member
There was a problem hiding this comment.
We shouldn't instantiate a method on each call to this method. Instead just copy paste the method in both places.
You should also be able to do just this: sorted(self.entities, key=lambda x: self.entities.name)
Contributor
Author
There was a problem hiding this comment.
Right, that key extraction ended up a bit redundant. I inlined the short version now.
Merged
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
When used in a frontend view, having things like
group.all_scriptsassume a new random order on each restart is annoying. This sorts them by name instead.Related issue (if applicable): fixes #6557
Example entry for
configuration.yaml(if applicable):Checklist:
If the code does not interact with devices:
toxrun successfully.