ZWave: Add reset service to meters#7676
Merged
Merged
Conversation
|
@turbokongen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob, @andrey-git and @armills to be potential reviewers. |
Contributor
|
Why index 33? Could you point to documentation? |
Contributor
Author
andrey-git
approved these changes
May 20, 2017
Contributor
andrey-git
left a comment
There was a problem hiding this comment.
Ouch. This is ugly :(
Contributor
|
Even though it looks like we'll only ever have the one, I think it's probably worth adding to |
Contributor
Author
|
You cant reset only one index of the command class. The button resets all meters of the instance. |
Contributor
|
I just meant adding |
emlove
approved these changes
May 20, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This adds a reset_node_meters service to zwave that can let the user reset values in the command_class_meter class. (I.e. kWh meter) This "button" will be present at index 33 of the values if the node supports it.
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#2674