Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not to Tox #76582

Merged
merged 2 commits into from
Nov 23, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .dockerignore
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ docs
.vscode

# Test related files
.tox
tests

# Other virtualization methods
Expand Down
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ pip-log.txt

# Unit test / coverage reports
.coverage
.tox
coverage.xml
nosetests.xml
htmlcov/
Expand Down
2 changes: 1 addition & 1 deletion script/bootstrap
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,4 @@ cd "$(dirname "$0")/.."

echo "Installing development dependencies..."
python3 -m pip install wheel --constraint homeassistant/package_constraints.txt
python3 -m pip install tox tox-pip-version colorlog pre-commit $(grep mypy requirements_test.txt) $(grep stdlib-list requirements_test.txt) $(grep tqdm requirements_test.txt) $(grep pipdeptree requirements_test.txt) $(grep awesomeversion requirements.txt) --constraint homeassistant/package_constraints.txt --use-deprecated=legacy-resolver
python3 -m pip install colorlog pre-commit $(grep mypy requirements_test.txt) $(grep stdlib-list requirements_test.txt) $(grep tqdm requirements_test.txt) $(grep pipdeptree requirements_test.txt) $(grep awesomeversion requirements.txt) --constraint homeassistant/package_constraints.txt --use-deprecated=legacy-resolver
2 changes: 1 addition & 1 deletion script/lint
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ echo '================================================='
echo '= FILES CHANGED ='
echo '================================================='
if [ -z "$files" ] ; then
echo "No python file changed. Rather use: tox -e lint\n"
echo "No python file changed.\n"
exit
fi
printf "%s\n" $files
Expand Down
8 changes: 4 additions & 4 deletions script/lazytox.py → script/lint_and_test.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
#!/usr/bin/env python3
"""
Lazy 'tox' to quickly check if branch is up to PR standards.
Quickly check if branch is up to PR standards.

This is NOT a tox replacement, only a quick check during development.
This is NOT a full CI/linting replacement, only a quick check during development.
"""
import asyncio
from collections import namedtuple
Expand Down Expand Up @@ -214,7 +214,7 @@ async def main():

print("=============================")
if not test_files:
print("No test files identified, ideally you should run tox")
print("No test files identified")
return

code, _ = await async_exec(
Expand All @@ -223,7 +223,7 @@ async def main():
print("=============================")

if code == 0:
printc(PASS, "Yay! This will most likely pass tox")
printc(PASS, "Yay! This will most likely pass CI")
else:
printc(FAIL, "Tests not passing")

Expand Down
2 changes: 1 addition & 1 deletion setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
url = https://www.home-assistant.io/

[flake8]
exclude = .venv,.git,.tox,docs,venv,bin,lib,deps,build
exclude = .venv,.git,docs,venv,bin,lib,deps,build
max-complexity = 25
doctests = True
# To work with Black
Expand Down
48 changes: 0 additions & 48 deletions tox.ini

This file was deleted.