Skip to content

Query in InfluxDB sensor is now templatable#7634

Merged
balloob merged 1 commit into
home-assistant:devfrom
titilambert:influxdb_sensor
Jun 2, 2017
Merged

Query in InfluxDB sensor is now templatable#7634
balloob merged 1 commit into
home-assistant:devfrom
titilambert:influxdb_sensor

Conversation

@titilambert
Copy link
Copy Markdown
Contributor

@titilambert titilambert commented May 17, 2017

Description:

Query in InfluxDB sensor is now templatable

Example entry for configuration.yaml (if applicable):

  - platform: influxdb
    queries:
      - name: influxdb_template_test
        field: 'value'
        group_function: 'mean'
        where: '"entity_id" = ''my_entity'' AND time > now() - {{ states.sensor.mysensor.state | int }}s'
        measurement: '"°C"'

Checklist:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@mention-bot
Copy link
Copy Markdown

mention-bot commented May 17, 2017

@titilambert, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bestlibre and @fabaff to be potential reviewers.

houndci-bot
houndci-bot reviewed May 17, 2017
View reviewed changes
Comment thread homeassistant/components/sensor/influxdb.py Outdated
Copy link
Copy Markdown

@houndci-bot houndci-bot May 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line too long (83 > 79 characters)

Comment thread homeassistant/components/sensor/influxdb.py Outdated
Copy link
Copy Markdown

@houndci-bot houndci-bot May 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

undefined name 'TemplateError'

Comment thread homeassistant/components/sensor/influxdb.py Outdated
Copy link
Copy Markdown

@houndci-bot houndci-bot May 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

undefined name 'template'

balloob
balloob requested changes May 17, 2017
View reviewed changes
Comment thread homeassistant/components/sensor/influxdb.py Outdated
Copy link
Copy Markdown
Member

@balloob balloob May 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should only instantiate templates using voluptuous. So use cv.template as a validator and set the hass object on it if it is not None.

Copy link
Copy Markdown
Contributor Author

@titilambert titilambert May 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed !

houndci-bot
houndci-bot reviewed May 17, 2017
View reviewed changes
Comment thread homeassistant/components/sensor/influxdb.py Outdated
Copy link
Copy Markdown

@houndci-bot houndci-bot May 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

undefined name 'formated_query'

Copy link
Copy Markdown
Contributor Author

@titilambert titilambert May 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done !

Comment thread homeassistant/components/sensor/influxdb.py Outdated
Copy link
Copy Markdown

@houndci-bot houndci-bot May 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

local variable 'query_template' is assigned to but never used
undefined name 'formated_query'

Comment thread homeassistant/components/sensor/influxdb.py Outdated
Copy link
Copy Markdown

@houndci-bot houndci-bot May 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blank line contains whitespace

Copy link
Copy Markdown
Contributor Author

@titilambert titilambert May 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

houndci-bot
houndci-bot reviewed May 17, 2017
View reviewed changes
Comment thread homeassistant/components/sensor/influxdb.py Outdated
Copy link
Copy Markdown

@houndci-bot houndci-bot May 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

undefined name 'formated_query'

Comment thread homeassistant/components/sensor/influxdb.py Outdated
Copy link
Copy Markdown

@houndci-bot houndci-bot May 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

undefined name 'TemplateError'

Comment thread homeassistant/components/sensor/influxdb.py Outdated
Copy link
Copy Markdown

@houndci-bot houndci-bot May 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

local variable 'query_template' is assigned to but never used
undefined name 'template'
undefined name 'formated_query'

Comment thread homeassistant/components/sensor/influxdb.py Outdated
Copy link
Copy Markdown

@houndci-bot houndci-bot May 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blank line contains whitespace

@titilambert
Copy link
Copy Markdown
Contributor Author

titilambert commented May 18, 2017

Tests passed and all requests done !

balloob
balloob reviewed May 23, 2017
View reviewed changes
Comment thread homeassistant/components/sensor/influxdb.py Outdated
Copy link
Copy Markdown
Member

@balloob balloob May 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should render the template each time the sensor updates and we send a new query to influxdb, so add it in InfluxSensorData.

@titilambert
Copy link
Copy Markdown
Contributor Author

titilambert commented May 27, 2017

@balloob Changes done !

@balloob
Copy link
Copy Markdown
Member

balloob commented Jun 2, 2017

Top! Thanks 👍 🐬

@balloob balloob merged commit 613da30 into home-assistant:dev Jun 2, 2017
@balloob balloob mentioned this pull request Jun 2, 2017
Merged
@home-assistant home-assistant locked and limited conversation to collaborators Sep 4, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@balloob balloob balloob approved these changes

+1 more reviewer

@houndci-bot houndci-bot houndci-bot left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-signed integration: influxdb platform

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@titilambert @mention-bot @balloob @houndci-bot @balloobbot @homeassistant