-
-
Notifications
You must be signed in to change notification settings - Fork 38.2k
Exclude filter for event types #7627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
be7013a
add exclude filter for event types to recorder component
amigian74 6dd665e
corrected long line (279)
amigian74 31a32fe
change source code structure
amigian74 481f917
code cleanup
amigian74 95708c2
change source code structure
amigian74 ab86919
Merge branch 'dev' into event_type_filter
amigian74 5354625
Update __init__.py
balloob 43e2662
Update test_init.py
balloob File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -114,6 +114,18 @@ def _add_entities(hass, entity_ids): | |
| return [st.to_native() for st in session.query(States)] | ||
|
|
||
|
|
||
| def _add_events(hass, events): | ||
| with session_scope(hass=hass) as session: | ||
| session.query(Events).delete(synchronize_session=False) | ||
| for event_type, event_data in events.items(): | ||
| hass.bus.fire(event_type) | ||
| hass.block_till_done() | ||
| hass.data[DATA_INSTANCE].block_till_done() | ||
|
|
||
| with session_scope(hass=hass) as session: | ||
| return [ev.to_native() for ev in session.query(Events)] | ||
|
|
||
|
|
||
| # pylint: disable=redefined-outer-name,invalid-name | ||
| def test_saving_state_include_domains(hass_recorder): | ||
| """Test saving and restoring a state.""" | ||
|
|
@@ -131,6 +143,14 @@ def test_saving_state_incl_entities(hass_recorder): | |
| assert hass.states.get('test2.recorder') == states[0] | ||
|
|
||
|
|
||
| def test_saving_event_exclude_event_type(hass_recorder): | ||
| """Test saving and restoring an event.""" | ||
| hass = hass_recorder({'exclude': {'event_types': 'test'}}) | ||
| events = _add_events(hass, {'test': 'nothing', 'test2': 'something'}) | ||
| assert len(events) == 1 | ||
| #assert hass.e.get('test2.recorder') == states[0] | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. block comment should start with '# ' |
||
|
|
||
|
|
||
| def test_saving_state_exclude_domains(hass_recorder): | ||
| """Test saving and restoring a state.""" | ||
| hass = hass_recorder({'exclude': {'domains': 'test'}}) | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still way too difficult. Just add this
elif event.event_type == EVENT_TIME_CHANGED::