Skip to content

Abort tests when instances leaked#7623

Merged
pvizeli merged 1 commit into
devfrom
stop-instance-check
May 17, 2017
Merged

Abort tests when instances leaked#7623
pvizeli merged 1 commit into
devfrom
stop-instance-check

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented May 17, 2017

Description:

This will abort the test run when instances are leaked instead of raising an asserting error for this and every subsequent error (which pretty much ruins the logs).

Most of the times these errors are because our detection for calling a threaded helper from inside async is accidentally triggered. Not sure yet how to get around these false positives.

Checklist:

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@mention-bot
Copy link
Copy Markdown

@balloob, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fabaff, @MrMep and @kellerza to be potential reviewers.

@pvizeli pvizeli merged commit a068efc into dev May 17, 2017
@balloob balloob deleted the stop-instance-check branch May 18, 2017 02:08
@home-assistant home-assistant locked and limited conversation to collaborators Sep 4, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants