Add service to set nest away/home modes#7619
Merged
Merged
Conversation
* New service `nest.set_mode` * Update the NestDevice object to export the local structures
Contributor
|
@mattsch, thanks for your PR! By analyzing the history of the files in this pull request, we identified @technicalpickles, @fabaff and @pvizeli to be potential reviewers. |
pvizeli
requested changes
May 30, 2017
|
|
||
| def set_mode(service): | ||
| """Set the home/away mode for a Nest structure.""" | ||
| if 'structure' in service.data: |
|
|
||
| AWAY_SCHEMA = vol.Schema({ | ||
| vol.Required(ATTR_HOME_MODE): cv.string, | ||
| vol.Optional(ATTR_STRUCTURE): vol.All(cv.ensure_list) |
Member
There was a problem hiding this comment.
Please validate the structure here like cv.string
Contributor
Author
|
@pvizeli I think I have those changes in properly, let me know if I misunderstood. |
balloob
approved these changes
Jun 5, 2017
Member
|
Thanks! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
nest.set_modePull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#2645
Example entry for
configuration.yaml(if applicable):None
Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass