media_player.squeezebox: Do not fail in case no players are connected, in which case squeezeserver will return a result without player_loop.

[molobrakos]

Do not fail in case no players are connected, in which case squeezeserver will return a result without player_loop.

Description:

Related issue (if applicable): fixes #

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

• Local tests with tox run successfully. Your PR cannot be merged unless tests pass
• New dependencies have been added to the REQUIREMENTS variable (example).
• New dependencies are only imported inside functions that use them (example).
• New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
• New files were added to .coveragerc.

If the code does not interact with devices:

• Local tests with tox run successfully. Your PR cannot be merged unless tests pass
• Tests have been added to verify that the new code works.

[mention-bot]

@molobrakos, thanks for your PR! By analyzing the history of the files in this pull request, we identified @persandstrom, @dasos and @fabaff to be potential reviewers.

[molobrakos]

Stack trace for reference:

2017-05-15 11:23:31 ERROR (MainThread) [homeassistant.components.media_player] Error while setting up platform squeezebox
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/site-packages/homeassistant/helpers/entity_component.py", line 150, in _async_setup_platform
    entity_platform.async_schedule_add_entities, discovery_info                                                                                                             File "/usr/local/lib/python3.6/site-packages/homeassistant/components/media_player/squeezebox.py", line 75, in async_setup_platform
    players = yield from lms.create_players()
  File "/usr/local/lib/python3.6/site-packages/homeassistant/components/media_player/squeezebox.py", line 98, in create_players
    for players in data['players_loop']:
KeyError: 'players_loop'

[pvizeli]

Can you also add the available property to entity?

[pvizeli]

Ping

[molobrakos]

I guess that should be possible ... maybe for another pr later?

[balloob]

I'm fine with that for a future PR.

[bdurrer]

this solves issue #6569 (but not the flaw that the component only looks for players exactly once at startup)

[molobrakos]

I agree it would be nice if the component checked for players more than once at startup. And also provided the available property as (suggested above).

[molobrakos]

I haven't tested this (not at home), but the periodically checking of newly connected players might already work because of netdisco/discovery sending out discovery requests periodically?

[dasos]

I think the component needs to listen to the discovery event: https://home-assistant.io/developers/component_discovery/

…

On 05/06/2017 17:01, Erik Eriksson wrote: I haven't tested this (not at home), but the periodically checking of newly connected players might already work because of netdisco/discovery sending out discovery requests periodically? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7617 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AG7zxxJqdXoxc4kMSt1h7PJtq9ah_rbhks5sBCZ0gaJpZM4NczEo>.