Osram lightify Removed wrong assignment#7615
Merged
Merged
Conversation
self._brightness is assigned with the returned value of the set_luminance() function, which is always equal to None.
Contributor
Contributor
Author
|
I have signed the CLA now. thanks for the support |
Contributor
|
Looks good 👌. Welcome! |
ghost
added
integration: osramlightify
and removed
platform: light.osramlightify
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
self._brightness was assigned with the returned value of the
set_luminance() function, which is always equal to None. I found this bug using a sensor to control a lightify light. I tested the correction with my setup and it works as expected.